starknet_committer,starknet_patricia,starknet_patricia_storage: support contract address prefix#10858
Conversation
|
This change is |
nimrod-starkware
left a comment
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)
ArielElp
force-pushed
the
ariel/add_serde_errors
branch
from
4b39ed1 to
4b32085
Compare
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
125914b to
0371ece
Compare
yoavGrs
left a comment
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status:
ArielElp
force-pushed
the
ariel/add_serde_errors
branch
from
4b32085 to
dd10700
Compare
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
0371ece to
933c3f3
Compare
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArielElp).
a discussion (no related file):
- why do you need
Cow? - why is the PR title "support contract address prefix"?
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
f791251 to
eb93872
Compare
ArielElp
force-pushed
the
ariel/add_serde_errors
branch
from
f51d69b to
384f2ca
Compare
ArielElp
left a comment
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @yoavGrs).
a discussion (no related file):
Previously, dorimedini-starkware wrote…
- why do you need
Cow?- why is the PR title "support contract address prefix"?
Previously there was only constants prefixes (inner nde --> "inner node" or some constant per leaf type for leaf).
With index layouts, I have prefixes which are either constants (the static lifetime borrowed variant of Cow), or, for the storage trie, prefixes that depend on a dynmaically constructed ContractAddress (the owned variant).
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
eb93872 to
9baa41f
Compare
ArielElp
force-pushed
the
ariel/add_serde_errors
branch
from
384f2ca to
40351f5
Compare
ArielElp
changed the base branch from
ariel/add_serde_errors
to
graphite-base/10858
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
9baa41f to
8ae5406
Compare
ArielElp
force-pushed
the
graphite-base/10858
branch
from
40351f5 to
3bd24d9
Compare
ArielElp
changed the base branch from
graphite-base/10858
to
ariel/add_serde_errors
ArielElp
force-pushed
the
ariel/add_serde_errors
branch
from
3bd24d9 to
b4c834d
Compare
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
8ae5406 to
7ac0b04
Compare
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
7ac0b04 to
d2591b8
Compare
ArielElp
force-pushed
the
ariel/add_serde_errors
branch
from
b4c834d to
9a59bb0
Compare
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
d2591b8 to
dae7822
Compare
ArielElp
force-pushed
the
ariel/add_serde_errors
branch
from
9a59bb0 to
c17c0aa
Compare
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
dae7822 to
c9d93da
Compare
ArielElp
force-pushed
the
ariel/add_serde_errors
branch
from
c17c0aa to
20db9ea
Compare
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
c9d93da to
e57563d
Compare
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:
ArielElp
changed the base branch from
ariel/add_serde_errors
to
main-v0.14.1-committer
…rt contract address prefix
ArielElp
force-pushed
the
ariel/support_owned_db_prefixes
branch
from
e57563d to
1c97905
Compare
5 participants
No description provided.